Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cookiecutter to es6 #104

Closed
jasongrout opened this issue Sep 2, 2022 · 1 comment · Fixed by #105
Closed

Update cookiecutter to es6 #104

jasongrout opened this issue Sep 2, 2022 · 1 comment · Fixed by #105

Comments

@jasongrout
Copy link
Member

@audunsh pointed out that https://github.com/jupyter-widgets/widget-cookiecutter/blob/6134771c6f2d7c275b186ff0cc00839be8d067b6/%7B%7Bcookiecutter.github_project_name%7D%7D/js/lib/example.js still uses Backbone.extend instead of es6 classes, so is not compatible with ipywidgets 8. We should fix this ASAP.
jasongrout added a commit to jasongrout/widget-cookiecutter that referenced this issue Sep 3, 2022
@jasongrout
Update to es6 modules and more modern js syntax
184cf91 
Fixes jupyter-widgets#104
@jasongrout jasongrout mentioned this issue Sep 3, 2022
Merged
jasongrout added a commit to jasongrout/widget-cookiecutter that referenced this issue Sep 3, 2022
@jasongrout
Update to es6 modules and more modern js syntax
95fa787 
Fixes jupyter-widgets#104
@jasongrout
Copy link
Member Author

I submitted a PR at #105

@dou-du dou-du mentioned this issue Oct 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to es6 modules and more modern js syntax jasongrout/widget-cookiecutter
1 participant
@jasongrout