Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make react components protected methods of CommentWidget #142

Open
cameron-toy opened this issue Aug 30, 2021 · 0 comments
Open

Make react components protected methods of CommentWidget #142

cameron-toy opened this issue Aug 30, 2021 · 0 comments
Assignees
@srirag-vuppala
Labels
API refactor

Comments

@cameron-toy
Copy link
Collaborator

cameron-toy commented Aug 30, 2021 •
edited
Loading

If someone wants to change a single piece of a comment widget (the timestamp, for example) they have to completely re-write the render method of whatever class they have extending CommentWidget.

However, if all the react components that make up a comment widget are moved into protected methods of CommentWidget, only a single component method needs to be overridden (renderTimestamp, for example).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srirag-vuppala srirag-vuppala

Labels
API refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cameron-toy @srirag-vuppala