Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PostgreSQL as a storage delegate #15

Closed
wants to merge 4 commits into from

Conversation

0mar
Copy link

@0mar 0mar commented Jun 24, 2024

  • Using psycopg2 as a driver
  • Inspired by commonhealth_cloud_storage_client.sqlite_delegate.py

NB:

  • Postgres has a key-value store extension hstore. I didn't use it because it looks like it's meant to store key-value metadata per row, instead of being its own table.
  • Postgres has JSON support. Also didn't use that
  • I'll write tests in the next PR

@0mar
Copy link
Author

0mar commented Jun 26, 2024

@minrk This PR is ready for review now

@0mar 0mar marked this pull request as ready for review June 26, 2024 11:00
@minrk
Copy link
Member

minrk commented Aug 8, 2024

@0mar and I have reviewed this, and the updated plan for CHCS means we aren't going to pursue it. We are exploring what the new CHCS integration may look like, and various SMART-on-FHIR integrations for JupyterHub

@minrk minrk closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants