Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff option to deploy.py #2804

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add diff option to deploy.py #2804

merged 1 commit into from
Dec 7, 2023

Conversation

manics
Copy link
Member

@manics manics commented Nov 1, 2023

I worked on this in #2698 but decided to make it into a seperate PR so we can discuss whether it's useful.

Adds a --diff option that uses kubectl diff (builtin) and helm diff (requires https://github.com/databus23/helm-diff) which is useful for local development.

It's not ideal since if there's a diff it shows the whole file instead of just the changed region, and CHP/hub will always show a difference because helm diff always generates a random token instead of fetching the CHP token.

@minrk
Copy link
Member

minrk commented Nov 10, 2023

This is great!

If it's useful for reference, I've used this script to check out helm-diffs for mybinder.org for some time.

specifically piping helm-diff through | grep -C 1 -v '^[[:space:]]' to limit the output to nearby changes.

@manics manics marked this pull request as ready for review November 19, 2023 22:49
@manics
Copy link
Member Author

manics commented Nov 19, 2023

I've belatedly realised helm diff includes a --context argument!

@manics manics merged commit a28afa7 into jupyterhub:main Dec 7, 2023
2 checks passed
@manics manics deleted the diff branch December 7, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants