Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgitpuller chrome extension not working when pulling branches other than main #289

Open
rohanjha123 opened this issue Jan 29, 2023 · 6 comments
Labels

Comments

@rohanjha123
Copy link

The nbgitpuller doesn't generate the right link when pulling branches other than main. When I tried pulling this file to data100.datahub.berkeley.edu using the chrome extension, the load failed. However, when I manually input all the info here and tried again, the pull succeeded, causing me to believe it's an issue with the chrome extension. A photo of the manual input can be seen below.
Screen Shot 2023-01-29 at 11 21 46 AM

Expected behaviour

The link loads properly

Actual behaviour

The chrome extension file redirect doesn't load properly. Instead, the following error message pops up
Screen Shot 2023-01-29 at 11 16 27 AM

How to reproduce

Use the chrome extension to generate a nbgitpuller link for this file

Your personal set up

  • OS:
    macOS 11.3.1
  • Version(s):
    nbgitpuller 1.1.0, jupyterhub 3.1.0, notebook==6.4.12, jupyterlab==3.4.5, python==3.9
Full environment

The full environment can be found here and here.

Configuration
# jupyterhub_config.py
Logs
@welcome
Copy link

welcome bot commented Jan 29, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@balajialg
Copy link

@yuvipanda FYI!

@rohanjha123
Copy link
Author

Friendly reminder @yuvipanda! Fixing this issue will be very helpful for the data 100 testing workflow

@yuvipanda
Copy link
Contributor

Hi @balajialg and @rohanjha123! Unfortunately I don't think I have time to look into this right now :( However, if you can make a PR to the repo (which is at https://github.com/yuvipanda/nbgitpuller-link-generator-webextension), I can take a look. Otherwise it might be a while before I can look at this.

@balajialg
Copy link

@yuvipanda Thanks. I will sync up with @rohanjha123 to figure out ways to create PR to this repo.

@ericvd-ucb
Copy link

ericvd-ucb commented May 10, 2023

@rohanjha123 @balajialg - i am gonna make a comment on Webextension where you should be able to make the PR

yuvipanda/nbgitpuller-link-generator-webextension#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants