-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nbgitpuller chrome extension not working when pulling branches other than main #289
Comments
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗 |
@yuvipanda FYI! |
Friendly reminder @yuvipanda! Fixing this issue will be very helpful for the data 100 testing workflow |
Hi @balajialg and @rohanjha123! Unfortunately I don't think I have time to look into this right now :( However, if you can make a PR to the repo (which is at https://github.com/yuvipanda/nbgitpuller-link-generator-webextension), I can take a look. Otherwise it might be a while before I can look at this. |
@yuvipanda Thanks. I will sync up with @rohanjha123 to figure out ways to create PR to this repo. |
@rohanjha123 @balajialg - i am gonna make a comment on Webextension where you should be able to make the PR |
The nbgitpuller doesn't generate the right link when pulling branches other than main. When I tried pulling this file to data100.datahub.berkeley.edu using the chrome extension, the load failed. However, when I manually input all the info here and tried again, the pull succeeded, causing me to believe it's an issue with the chrome extension. A photo of the manual input can be seen below.
Expected behaviour
The link loads properly
Actual behaviour
The chrome extension file redirect doesn't load properly. Instead, the following error message pops up
How to reproduce
Use the chrome extension to generate a nbgitpuller link for this file
Your personal set up
macOS 11.3.1
nbgitpuller 1.1.0, jupyterhub 3.1.0, notebook==6.4.12, jupyterlab==3.4.5, python==3.9
Full environment
The full environment can be found here and here.
Configuration
# jupyterhub_config.py
Logs
The text was updated successfully, but these errors were encountered: