Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development notes on how to run tests from within a docker container #123

Open
consideRatio opened this issue May 27, 2023 · 1 comment

Comments

@consideRatio
Copy link
Member

I think it would be good to help users test this software from within a docker container with systemd running. Like that, users wouldn't need to have systemd installed for example, and we could let systemdspawner run tests with system users without associated risks of doing it on the host system directly.

I don't think its in scope for our test suite to automatically build a docker image to run tests in, as we then need to maintain those image builds etc. With that said, I think its in scope to have an example Dockerfile with notes on how to build it, start it with the local folder mounted, and run pytest from inside it.

For reference, the TLJH distribution of jupyterhub let's pytest build a systemd image and run tests inside it etc. I think we should avoid that complexity in this project, but I think we can copy paste a lot from that project's Dockerfile that includes systemd.

@manics
Copy link
Member

manics commented May 29, 2023

I agree we shouldn't maintain another systemd container image in this repo. However since the work has already been done in TLJH and we're maintaining it, could we move that systemd container into a separate repo, and use it in both projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants