-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main menu example does not add menu, just the command #265
Comments
We previously discussed it in https://discourse.jupyter.org/t/how-do-i-change-available-menus-in-the-mainmenu-bar/26322/4 where I stated that there is no apparent issue in this repository because we are regularly testing the examples and there is an integration test which most recently was passing: extension-examples/main-menu/ui-tests/tests/main-menu.spec.ts Lines 22 to 31 in 871fbe1
I re-triggered CI with #266 and the tests is still passing, on all three operating systems that we are testing: @ohrely I see that you added a "good first issue" label. Did you also encounter this issue? Shall we switch the label to "help wanted" rather than "good first issue" since this appears puzzling even to seasoned contributors? |
I also built the example locally and it works fine: Here is the full log of the installation:
We really would need you @gutow or @ohrely to share a reproducible repository in which you cannot get it to work as otherwise it is hard to help. There is only one way things work but an infinite number of ways to break it. |
Thank you for looking at this. I got most of the things I need working done, so have come back around to this. A clean install of the example now works for me. I even tried messing it up by setting up a pipenv just in the main-menu example directory. It is possible that I somehow got a bad download with something missing. However, there is something still unclear about the example because I cannot get a working schema based menu starting with the copier template. Undocumented things that I tried:
There must be something more that I am overlooking as I read the various files in the example. The example attempt is accessible here: https://github.com/gutow/minimal-jlab-menu This example does add the working command to open the repository of the attempt to the command palette. I think there is a documentation issue, not an outright flaw in the example. Maybe the tags should be changed to "Needs Documentation" or equivalent? Thanks. |
Sorry, I was too hasty with the "good first issue" label. I have not encountered the issue myself. |
@gutow I had a quick look and it seems that you might be missing the extension-examples/main-menu/package.json Lines 94 to 98 in 871fbe1
It would have been added by "extension-template" if you had selected Maybe we should reword it in the template to "Does the extension have user settings or schema-defined UI elements?" |
@krassowski Thank you. I have verified that adding The change to the wording in the copier template would help. I also think there should be a check-off list of all the places things need to be set. Based on my user experience I think the list should be something like this.
I think that would get most JLab novices, such as myself, started. I do have some other ideas on things that would be nice to include in this and some other examples, but do not have time to polish them into pull requests at the moment. When I find time I will do that. |
Description
When I follow the instructions and run the main-menu example, no menu is added just the command in the command pallet.
I believe this is because some automatic loading of the schema for the menu does not work. I tried to use the code in a new project using the latest stable jupyter (^4.0.0). It behaved the same.
Reproduce
Follow the instructions in the example project.
No menu is added to Jupyter.
Expected behavior
I expect a menu to be added as per the description and animation.
Context
In a new clean project, I am able to build a menu using code such as this:
The main-meu example in this repository is trying to do something else that does not appear to work currently.
Troubleshoot Output
Command Line Output
Browser Output
The text was updated successfully, but these errors were encountered: