You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In JupyterLab, CodeMirror does not tag items like brackets, colons, semi-colons, parentheses, and commas as punctuation. pygments flags such elements as punctuation and jupyterlab_pygments styles them as --jp-mirror-editor-punctuation-color, leading to a mismatch in color for these elements. Don't think this is a big deal, and one could argue that pygments is doing a better job, but it does seem to be inconsistent.
Reproduce
Create a JupyterLab notebook with the cell a = [1,2,3,4]; print(a[1:3]) and save it as demo.ipynb
Run nbconvert --to html --template lab demo.ipynb
Inspect the differences in the output html file and the original notebook rendered in JupyterLab. The colors for brackets, colons, semi-colons, parentheses, and commas are blue in the html file and the default text color in JupyterLab.
Expected behavior
These elements would be the default text color.
Context
Operating System and version: macOS 12.4
Browser and version: Safari 15.5
JupyterLab version: 3.4.2
Suggested fix
Comment out the line setting the punctuation color here:
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋
Description
In JupyterLab, CodeMirror does not tag items like brackets, colons, semi-colons, parentheses, and commas as punctuation. pygments flags such elements as punctuation and jupyterlab_pygments styles them as --jp-mirror-editor-punctuation-color, leading to a mismatch in color for these elements. Don't think this is a big deal, and one could argue that pygments is doing a better job, but it does seem to be inconsistent.
Reproduce
a = [1,2,3,4]; print(a[1:3])
and save it asdemo.ipynb
nbconvert --to html --template lab demo.ipynb
Expected behavior
These elements would be the default text color.
Context
Suggested fix
Comment out the line setting the punctuation color here:
jupyterlab_pygments/jupyterlab_pygments/style.py
Line 132 in 7070bc1
The text was updated successfully, but these errors were encountered: