-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change in frame count between 3.0.6 and 3.1.0 #573
Comments
Same for us, had to downgrade to 3.0.6 |
These are the two changes that made it to 3.1.0: #501, #502 I suspect that this change caused the issue (the only thing that possibly could have impact). The question is indeed how we didn't catch it in the tests so a minimal repro would be very helpful, @daiscog. @MillerSvt do you have any idea why this could happen? |
I need minimal repro. It seems some tests, was written incorrect. But I have no idea why.
@Romjkez Have you also moved 18 frames in your project? |
Are there any new on this? Same Issue here, all Frame Counts are 18 or 19 lower as expected. |
Please create minimal reproduction repository. |
After upgrading to 3.1.0 some of our tests are now failing without any changes to the test code. For example, the following is showing the actual values being emitted 18 frames earlier than expected:
The tests pass again after dropping back to version 3.0.6, with no other changes.
I've not had time yet to look into this in detail, but I will at some point try to reduce it to a minimal reproducible example and post more detail below.
Sharing this here for the time being for awareness and so others can investigate in the mean time if they want.
The text was updated successfully, but these errors were encountered: