Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a fixed version of core's InstallCommand #36

Closed
joachim-n opened this issue Jun 25, 2024 · 2 comments
Closed

add a fixed version of core's InstallCommand #36

joachim-n opened this issue Jun 25, 2024 · 2 comments

Comments

@joachim-n
Copy link

Core's InstallCommand makes assumptions about Drupal's location. There's no workaround for this -- they're hardcoded.

One fix would be for this add-on to provide its own fixed version of the InstallCommand class -- there is one in the MR for https://www.drupal.org/node/1792310.

Though there's also an issue to make Drush commands work with this - #29 - in which case fixing drupal install might not be necessary.

@justafish
Copy link
Owner

This addon is geared towards developing core with the git checkout so it does make an assumption about Drupal's location. Please feel free to re-open if this changes in core.

@joachim-n
Copy link
Author

It is, but it would be good if it also supported developing core when installed using a Composer path repository. This is the standard way of developing a Composer package in the wider context of a project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants