Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with ui-bootstrap >= 0.11.0 #4

Open
pirumpi opened this issue Jan 27, 2015 · 6 comments
Open

Doesn't work with ui-bootstrap >= 0.11.0 #4

pirumpi opened this issue Jan 27, 2015 · 6 comments
Labels

Comments

@pirumpi
Copy link

pirumpi commented Jan 27, 2015

This directive does not work with the latest version of bootstrap and angular
http://plnkr.co/edit/dXPYohDJGdvNadjugff7?p=preview

@justin-lau
Copy link
Owner

Thank you for the bug report.

It is due to some breaking changes introduced in ui-bootstrap 0.11. Using ui-bootstrap 0.10.0 with angular 1.4.0-beta.2 works fine.

Since I planned to remove ui-bootstrap dependency on future releases, this issue won't be fixed.

@justin-lau justin-lau changed the title doesn't work Doesn't work with ui-bootstrap >= 0.11.0 Jan 30, 2015
@astanciu
Copy link

astanciu commented Nov 5, 2015

So any updates here?

@justin-lau
Copy link
Owner

Hi @astanciu, indeed I'm working on an version 2 that supports AngularJS 1.4.x and Bootstrap 3. It also no longer depends on ui-bootstrap. It was really close to finish a couple of weeks ago, but I have been occupied on my day works. I hope I can release it within November.

@solarisfire
Copy link

So any updates here?

@rapheki
Copy link

rapheki commented May 20, 2016

i had a similar issue, you need to modifiy the ui-iconpicker.js file and replace in line 156 (the templates/iconpicker.html):

  • "dropdown>" to "uib-dropdown>"
  • "dropdown-toggle>" to "uib-dropdown-toggle>"

@jcastro7
Copy link

i had a similar issue, you need to modifiy the ui-iconpicker.js file and replace in line 156 (the templates/iconpicker.html):

  • "dropdown>" to "uib-dropdown>"
  • "dropdown-toggle>" to "uib-dropdown-toggle>"

Try with
"$templateCache", function($templateCache) { return $templateCache.put("templates/iconpicker.html", "<span class=\"btn-group ui-iconpicker\" ng-class=\"{ disabled: disabled }\">\n "+ "<button type=\"button\" class=\"btn btn-default dropdown-toggle\" data-toggle=\"dropdown\" aria-expanded=\"true\">"+ "<i class=\"{{ iconClass }}\"></i><span class=\"caret\"></span>\n "+ "</button>\n "+ "<ul class=\"dropdown-menu\" role=\"menu\">\n "+ "<li ng-repeat=\"class in availableIconClasses\">\n "+ "<button class=\"btn btn-default\" type=\"button\" ng-click=\"$parent.iconClass = class\"><span class=\"{{ class }}\"></span></button>\n "+ "</li>\n "+ "</ul>\n "+ "<input name=\"{{ name }}\" type=\"text\" value=\"{{ iconClass }}\" ng-if=\"name\" />\n"+ "</span>"); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants