-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows #17
Comments
Hi @justinkambic, I think I hit the same wall.. instead of setting the path to the binaries, I had set libraw as a git submodule, node-gyp builds ok but running prebuildify says at the end prebuildify log:
|
Hi @labsforge - sorry for the ultra-late response here. Did you ever get this to work ok? To be honest, it has been literal years since I tried to get libraw.js to work cleanly on Windows and I still don't have access to a reliable Windows dev environment. If you or anyone else is able to configure libraw.js in a manner that works, I'd be super excited to accept a PR that generates the binary properly so I can build it and include it in the next release. My open source time is extremely constrained these days, so it's not something I am likely to add on my own. |
It's generally known that Windows is the most difficult platform to debug for
node-gyp
. I've spent considerable amounts of time trying to configure multiple versions ofMSBuild
to get a working build for Windows. My desire is to support Windows, Linux, and macOS, but at this point it has been consuming too much of my time to pursue this any further, and I don't have access to an easily-cleaned build machine like I do for macOS, and I use Docker when supporting Ubuntu.It's possible to build
libraw.js
for Windows if you build/install LibRaw and are able create a viable native node executable on Windows 10. I've gotten to the point wherenode-gyp
reports a successful build, but opening the output file with Dependency Walker shows a number of Windows libs are missing, andlibraw.dll
is also absent when it's required. Below is the segment of thenode-gyp
binding.I also had difficulty building LibRaw on Windows. I attempted doing this with the Windows instructions, MingW, and Cygwin; all of them ended up erroring out when running
make
. This is probably a result of issues in my native environment.To resolve this issue, I'd love if we could create a GitHub Action similar to the CI process that configures a Windows build pipeline, and can successfully run the tests. If you're experienced with C++ builds and running node-gyp successfully on Windows I'd love your input here.
The text was updated successfully, but these errors were encountered: