Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more regression data for #132 + other test strengthening #134

Open
pseeth opened this issue Sep 25, 2020 · 1 comment
Open

Create more regression data for #132 + other test strengthening #134

pseeth opened this issue Sep 25, 2020 · 1 comment

Comments

@pseeth
Copy link
Collaborator

pseeth commented Sep 25, 2020

We need more regression data for #132 to make sure we don't break these changes in future PRs.

Namely, these comments in the CR should be addressed:

  • Can we add an edge case in the tests where all the source files we're putting into the soundscape are silent? Just want to make sure nothing breaks. The scaling factor will end up at 1e10 in that case, but it should be fine when multiplied by all zeros. But might be a good code path to make sure this regularization is working going into the future.
  • I need to add a no_audio case for generate_from_jams, but in the long run we should add no_audio cases elsewhere. Shall we open an issue?
  • Should we add regression data for the cases where clipping is happening? Or when peak_normalization is on? Would be reassuring to see regression data for those cases going forward.
@justinsalamon
Copy link
Owner

Also, we should specifically add tests that combine clipping + reverb, to make sure the two operations work well in for the order in which they are applied (in all likelihood we'll start with applying reverb BEFORE peak normalization)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants