fix module FQCN issue for import modules (ansible#220)

Signed-off-by: hirokuni-kitahara <[email protected]>
justjais · Jun 3, 2024 · b80457c · b80457c
1 parent c48a069
commit b80457c
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/ansible_risk_insight/rules/P001_module_name_validation.py b/ansible_risk_insight/rules/P001_module_name_validation.py
@@ -77,14 +77,20 @@ def process(self, ctx: AnsibleRunContext):
 
         # include_role, import_role
         elif task.spec.executable_type == ExecutableType.ROLE_TYPE:
-            if "ansible.builtin." not in task.spec.module:
+            if "ansible.builtin." in task.spec.module:
+                resolved_fqcn = task.spec.module
+                correct_fqcn = resolved_fqcn
+            else:
                 resolved_fqcn = "ansible.builtin." + task.spec.module
                 correct_fqcn = resolved_fqcn
                 need_correction = True
 
         # include_tasks, import_tasks
         elif task.spec.executable_type == ExecutableType.TASKFILE_TYPE:
-            if "ansible.builtin." not in task.spec.module:
+            if "ansible.builtin." in task.spec.module:
+                resolved_fqcn = task.spec.module
+                correct_fqcn = resolved_fqcn
+            else:
                 resolved_fqcn = "ansible.builtin." + task.spec.module
                 correct_fqcn = resolved_fqcn
                 need_correction = True