Improve memory accounting #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just curious about any updates on this. |
|
I haven’t made any progress on this. I usually find time to do maintenance on this project around Christmas, so that’s the earliest I would work on it. I if I recall, I hit issues trying to convince Emscripten & quickjs to behave together the way I want — it should be possible but it seems to require more invasive patching of quickjs than I had patience for at the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
malloc_usable_sizeand other previously linux-only features that Emscripten can actually emulate. This should improve memory accounting.runtime.computeMemoryUsage()now directly returns a host Javascript object, instead of a handle. We no longer need a "system context" to pass the result back as a JSValue.runtime.getSystemContext()since it has no callers and isprivatebigintinstead ofnumber.Fixes #206