Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding this plugin to vim source #13

Open
bruno- opened this issue Oct 7, 2013 · 2 comments
Open

Consider adding this plugin to vim source #13

bruno- opened this issue Oct 7, 2013 · 2 comments

Comments

@bruno-
Copy link
Collaborator

bruno- commented Oct 7, 2013

Hi @juvenn,
I think this plugin is useful enough so we can consider adding it to vim source.

Bram Molenaar seems to be pretty ok with that idea. He is openly calling for contributions like this. For example, see this syntax help section (second paragraph).

Also, here's the link to discussion where Bram seems to be ok with adding a pretty obscure (almost proprietary) syntax file to vim source.
Compared to that, I think mustache is pretty mainstream file type that a lot of people use.

Now, before we take that step, I think we should take some time, and polish this plugin before posting it on vim-dev mailing list and to vim maintainer Bram.

Here are some things I noticed:

  • there is also this relatively popular project vim-handlebars. Our project, and that one are almost the same. We might consider contacting the maintainer of that project and merge projects to a single one (for example: vim-mustache-handlebars).
    The plugin would be more useful that way, and I think that makes another good argument when submitting to vim source.
  • if not merging, vim-handlebars project had some good commits lately we could bring to our project too.
  • I think it would be possible to fix this issue

@juvenn , what do you think about these ideas?
Should we contact that maintainer of vim-handlebars and suggest merging to him?
I will start work on improving the the above suggested things over the next couple weeks.
Do you agree we should propose adding the project to vim source in the future?

Bruno

@juvenn
Copy link
Owner

juvenn commented Oct 7, 2013

Dear @bruno-

I'm more than glad to see it being merged into official vim, and also I
like the idea of merging this mustache and handlebars into an uniform one,
which might serve the community better.

So, let's definitely push this forward! Please try to contact the
maintainer, and let me know whatever I could help!

Thank you!

@bruno-
Copy link
Collaborator Author

bruno- commented Oct 13, 2013

Hey @juvenn,
I've written to vim-handlebars maintainer about the idea to merge and submit a plugin to official vim.
The thread is on this link.
Feel free to leave you ideas and comments too!

Bruno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants