You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, thanks for bidi - it's great, we have used it for frontend and backend routing for years and it has greatly simplified swaths of code around urls. If it didn't exist, we'd need to start by making something just like it (but ours would be worse).
iiuc, this should be a safe change, because the two-argument arity of static /decode always takes two strings. Maybe this would be a nice improvement to include in a future release.
Thanks again for your time and consideration.
The text was updated successfully, but these errors were encountered:
First, thanks for
bidi
- it's great, we have used it for frontend and backend routing for years and it has greatly simplified swaths of code around urls. If it didn't exist, we'd need to start by making something just like it (but ours would be worse).Low-priority note:
I get a reflection warning while compiling bidi:
It's right here:
bidi/src/bidi/bidi.cljc
Lines 19 to 20 in d943162
I experimented with this:
And it's cleaned up:
iiuc, this should be a safe change, because the two-argument arity of static
/decode
always takes two strings. Maybe this would be a nice improvement to include in a future release.Thanks again for your time and consideration.
The text was updated successfully, but these errors were encountered: