Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct how docker registry credentials are passed or documented #101

Open
RickMoynihan opened this issue Feb 17, 2022 · 1 comment
Open
Labels
bug Something isn't working
Milestone

Comments

@RickMoynihan
Copy link
Contributor

RickMoynihan commented Feb 17, 2022

The docstring states credentials should be supplied like this:

Credentials
:from-registry - map of :username and :password to string, used for pulling from registry
:to-registry - map of :username and :password to string, used for uploading to registry

However the opts on that api function are just passed directly into the jib namespace; and that expects the keys to be formatted like they are here:

to-registry-username
to-registry-password

I'm happy to work up a patch for this; but it's unclear to me what the intention is.

A work around to pass to credentials is to just call api/docker with :to-registry-username and :to-registry-password set.

@SevereOverfl0w
Copy link
Collaborator

The documentation is correct, the code is wrong.

@SevereOverfl0w SevereOverfl0w added this to the Stable milestone May 11, 2022
@SevereOverfl0w SevereOverfl0w added the bug Something isn't working label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants