Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken delegate pattern #2

Open
buscarini opened this issue Mar 20, 2024 · 0 comments
Open

Broken delegate pattern #2

buscarini opened this issue Mar 20, 2024 · 0 comments

Comments

@buscarini
Copy link

When using JWPlayerViewController to display videos we no longer allow the delegates within JWPlayer and JWPlayerView to be overridden. JWPlayerViewController needs to be the delegate to work properly, and allowing this behavior caused issues in certain utilizations of our SDK.

Really? you thought this was ok? and on a minor version change. 🤦🤦🤦
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@buscarini