Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support fabric in the new architecture (0.76+) #110

Open
Jmilham21 opened this issue Dec 18, 2024 · 2 comments
Open

[FEAT] Support fabric in the new architecture (0.76+) #110

Jmilham21 opened this issue Dec 18, 2024 · 2 comments
Labels
enhancement New feature or request Groomed JWP team has reviewed the ticket and deemed it necessary help wanted Extra attention is needed

Comments

@Jmilham21
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The new architecture implemented in React-Native 0.76 has become the default. This means this library needs to be modernized to play nicely with this.

Describe the solution you'd like

Remove the asynchronous bridge in this library in favor of the new architecture.

Describe alternatives you've considered

It is possible to Opt-Out for now, but this isn't ideal for long-term support

Additional context

On iOS, the library will still compile and run with the new architecture turned on, but nearly all functions and callbacks are broken.
On Android, there seems to be a possible build failure with the new architecture.

For those who want to help

This may turn into a larger project, and any additional effort from the community would be greatly appreciated.

@Jmilham21 Jmilham21 added enhancement New feature or request help wanted Extra attention is needed Groomed JWP team has reviewed the ticket and deemed it necessary labels Dec 18, 2024
@chaimPaneth
Copy link
Contributor

@Jmilham21 a while back I've started on this havn't gotten far though https://github.com/chaimPaneth/react-native-jw-media-player/tree/new-architecture

@Jmilham21
Copy link
Collaborator Author

Thanks @chaimPaneth! We will start looking into this over the next week and hopefully start making some progress (expecting to have some work done, if not all, this month) on a to-be-created branch. We'd love to get your feedback as we go and finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Groomed JWP team has reviewed the ticket and deemed it necessary help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants