Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IOS Menu appearing out of screen bounds / under bottom tabs #93

Open
cheynewallace opened this issue Oct 15, 2024 · 2 comments
Open
Labels
needs-info There isn't enough information. Please add more context

Comments

@cheynewallace
Copy link

cheynewallace commented Oct 15, 2024

Describe the bug
When opening the menu Audio & Quality menu on an IOS device, the menu appears at the bottom of the screen and is covered by bottom tab navigation.

Compare this to Android where the menu appears over the top of the player which seems like the correct placement.

To Reproduce
Stock standard JWPlayer? Nothing note worthy here to reproduce.

Expected behavior
Menu should appear in the correct positioning, assuming that is over the player and not as the foot of the screen.

Screenshots / Visual evidence
See a working Android example compared with the IOS example.

IPhone 15 Pro Emulator - IOS 17.5 (Broken example)
Screenshot 2024-10-15 at 4 22 25 PM

Android Pixel 6 Emulator (Working example)
Screenshot 2024-10-15 at 4 12 45 PM

Device(s) affected

  • Device: IPhone 15 Pro
  • OS: IOS 17.5

Additional context
Using latest jwplayer from this lib

@cheynewallace cheynewallace added the needs-grooming Has not been reviewed by codeowners for scope/validation label Oct 15, 2024
@sedatb
Copy link

sedatb commented Dec 17, 2024

still same issue

@Jmilham21
Copy link
Collaborator

@cheynewallace @sedatb This is generally the expected behavior of the player. The player menus and submenus will inflate from the bottom on iOS; it's just a difference in the designs for each platform and is a product of the native SDK, not this wrapper.

The potential issue I see is whether the Close button hides under your bottom navigation? Are you able to close the menu easily?

@Jmilham21 Jmilham21 added needs-info There isn't enough information. Please add more context and removed needs-grooming Has not been reviewed by codeowners for scope/validation labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-info There isn't enough information. Please add more context
Projects
None yet
Development

No branches or pull requests

3 participants