Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dir algorithm #13

Closed
wants to merge 2 commits into from
Closed

Dir algorithm #13

wants to merge 2 commits into from

Conversation

rangeroob
Copy link

fixes #12

@francescobbo
Copy link
Member

Hey, thanks for the pull request. Unfortunately the travis build has failed, due to a gem install error... can you take care of that?

Also, did you investigate why the new openssl is asking for 16 bytes instead of 32? Was it truncating to 16 bytes anyway previously?

Thanks.

@francescobbo francescobbo force-pushed the master branch 3 times, most recently from bb0c251 to 85175aa Compare September 6, 2017 19:49
@rangeroob
Copy link
Author

Hello I just fixed the pull request and to answer your questions yes it was previously working on ruby version 2.3.4 but I upgraded mid project and noticed it errors out on ruby version 2.4 even using your README's example

and I just found this on another projects github(attr-encrypted/encryptor#26) issue which pointed me to the change in openssl(ruby/ruby@ce63526)

@lizGraham9CB
Copy link

Is this going to get merged? I'm still seeing the "key must be 16 bytes" error when encrypting with dir.

@rangeroob
Copy link
Author

rangeroob commented Dec 1, 2018

Sadly @lizGraham9CB this pull request would not stop you from seeing that error message. This pull request that I did over a year ago basically changes the readme to use 16 bytes in the example and adds a test case to show that it errors out on anything later than ruby 2.4 with a byte size greater than 16. I believe it is not specific to this gem and has to do with OpenSSL. The links I provided in my previous message give some good examples to try to work around this issue.

@rangeroob rangeroob closed this by deleting the head repository Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the 'dir' Algorithm using bytes other than 16 on Ruby >= 2.4
3 participants