Skip to content
This repository was archived by the owner on Jan 31, 2023. It is now read-only.

add arrayFrom ponyfill for IE11, add yarn.lock, add /node_modules to … #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjsisley
Copy link

Add the array-from ponyfill to address #7 and rebassjs/rebass#239.

(Also added yarn.lock file and /node_modules to .gitignore).

@mjsisley
Copy link
Author

Hey @jxnblk, I know you have a million things going on and are busy making other dope stuff all the time.... but if possible, I'd really love to get rebass working in IE11 (because rebass is dope... and I need to support IE11).

Anyways, if there is anything else from me needed to get this done... please let me know.

@quin
Copy link

quin commented Jan 15, 2018

@jxnblk pls

@jxnblk
Copy link
Owner

jxnblk commented Feb 10, 2018

Thanks for putting this together and sorry for the delay!

  1. I do NOT want to add a lock file to a library like this
  2. Rather than a ponyfill, I think this issue could be solved with a hard-coded array

@mjsisley
Copy link
Author

Thanks for all your awesome stuff!

Okay, lock file makes sense. I think a hardcoded array would be preferable as well.

Feel free to close this or leave open until you get the hardcoded array you want together (so there is something visible until then)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants