Skip to content

Commit

Permalink
Refactor (#47)
Browse files Browse the repository at this point in the history
* docs: clean up javadoc

* perf: use lombok for enum getters
  • Loading branch information
jy95 authored Jan 28, 2025
1 parent 637d001 commit a77d58d
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 20 deletions.
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
package io.github.jy95.fds.common.types;

import lombok.Getter;

import java.util.List;

/**
* Represents the available display orders
*
* @author jy95
*/
@Getter
public enum DisplayOrder {
/**
* Display "method"
Expand Down Expand Up @@ -141,18 +144,13 @@ public enum DisplayOrder {
*/
TIMING_MODIFIER_EXTENSION(List.of("timing.modifierExtension"));

/**
* Getter for the <code>field</code>(s) covered by the display order
*/
private final List<String> fields;

DisplayOrder(List<String> fields) {
this.fields = fields;
}

/**
* <p>Getter for the field <code>fields</code>.</p>
*
* @return a {@link java.util.List} object
*/
public List<String> getFields() {
return fields;
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
package io.github.jy95.fds.common.types;

import lombok.Getter;

/**
* Enum representing the link words used to combine list elements.
*
* @author jy95
*/
@Getter
public enum LinkWord {
/**
* Represents the "and" link word.
Expand All @@ -15,18 +18,13 @@ public enum LinkWord {
*/
THEN("then");

/**
* Retrieves the value of the link word.
*/
private final String value;

LinkWord(String value) {
this.value = value;
}

/**
* Retrieves the value of the link word.
*
* @return The string value of the link word.
*/
public String getValue() {
return value;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
* R4 class for converting ratio objects to human-readable strings.
* Implements the Bill Pugh Singleton pattern for thread-safe lazy initialization.
*
* Author: jy95
*
* @author jy95
*/
public class RatioToStringR4 implements RatioToString<FDSConfigR4, Ratio> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
* R5 class for converting ratio objects to human-readable strings.
* Implements the Bill Pugh Singleton pattern for thread-safe lazy initialization.
*
* Author: jy95
*
* @author jy95
*/
public class RatioToStringR5 implements RatioToString<FDSConfigR5, Ratio> {
Expand Down

0 comments on commit a77d58d

Please sign in to comment.