New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOTDEFINED to be filtered #7

Open

pipauwel opened this issue May 31, 2018 · 1 comment

Collaborator

pipauwel commented May 31, 2018

A number of Product Building Element classes are used that are not in the Building Product ontology. This includes:

Covering-NOTDEFINED
Railing-NOTDEFINED
Footing-NOTDEFINED
Pile-NOTDEFINED
Slab-NOTDEFINED

I suggest to keep these elements out during conversion. If they are not defined, then why include them?

Collaborator

mathib commented Jun 1, 2018

We can assign their product superclass instead:

Covering
Railing
Etc.

jyrkioraskari added a commit that referenced this issue


          Merge pull request #7 from jyrkioraskari/master

41ef853

V2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment