Minor changes to test assertions

k0rdent · Nov 6, 2024 · 39faf3a · 39faf3a
1 parent a2ee854
commit 39faf3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/controller/multiclusterservice_controller_test.go b/internal/controller/multiclusterservice_controller_test.go
@@ -161,7 +161,8 @@ var _ = Describe("MultiClusterService Controller", func() {
 
 			By("having the valid service template status")
 			Expect(k8sClient.Get(ctx, serviceTemplateRef, serviceTemplate)).To(Succeed())
-			Expect(serviceTemplate.Status.Valid && serviceTemplate.Status.ValidationError == "").To(BeTrue())
+			Expect(serviceTemplate.Status.Valid).To(BeTrue())
+			Expect(serviceTemplate.Status.ValidationError).To(BeEmpty())
 
 			By("creating MultiClusterService")
 			err = k8sClient.Get(ctx, multiClusterServiceRef, multiClusterService)

diff --git a/internal/controller/template_controller_test.go b/internal/controller/template_controller_test.go
@@ -312,7 +312,8 @@ var _ = Describe("Template Controller", func() {
 
 			By("Having the valid cluster template status")
 			Expect(k8sClient.Get(ctx, client.ObjectKeyFromObject(clusterTemplate), clusterTemplate)).To(Succeed())
-			Expect(clusterTemplate.Status.Valid && clusterTemplate.Status.ValidationError == "").To(BeTrue())
+			Expect(clusterTemplate.Status.Valid).To(BeTrue())
+			Expect(clusterTemplate.Status.ValidationError).To(BeEmpty())
 			Expect(clusterTemplate.Status.Providers).To(HaveLen(2))
 			Expect(clusterTemplate.Status.ProviderContracts).To(HaveLen(2))
 			Expect(clusterTemplate.Status.Providers[0]).To(Equal(someProviderName))