pulling projectsveltos CRDs of version defined in Chart.yaml #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BROngineer
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
BROngineer
force-pushed
the
chore/issue-1040-maintain-sveltos-crds-version
branch
2 times, most recently
from
9fb9f57 to
4febff2
Compare
eromanova
reviewed
Feb 5, 2025
Makefile
Outdated
| generate-all: generate manifests templates-generate add-license projectsveltos-crds | ||
|
|
||
| .PHONY: projectsveltos-crds | ||
| projectsveltos-crds: yq |
There was a problem hiding this comment.
Suggested change
| projectsveltos-crds: yq | |
| projectsveltos-crds: $(YQ) |
There was a problem hiding this comment.
why replace yq target with $(YQ)?
BROngineer
force-pushed
the
chore/issue-1040-maintain-sveltos-crds-version
branch
from
30dcfbd to
74ccc13
Compare
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
BROngineer
force-pushed
the
chore/issue-1040-maintain-sveltos-crds-version
branch
from
74ccc13 to
a975af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1040