-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator [N] [CI] oracle-database-operator (v1.1.0) #5045
Conversation
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
2 similar comments
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
@haripate @tomasbakk I've been trying to create this pull request for our Operator (Oracle) but it's becoming impossible to walk-around some checks. Can I get some support from you? Thanks |
@psilberk I will take a look into it. |
There are couple of issues I found:
Let me know if you still face any issues. |
Thanks @haripate , I'll review this. |
@psilberk
|
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Thanks @haripate , but it looks like the signoff didn't work and there's another error (maybe because the signoff didn't work?): fatal: [localhost]: FAILED! => changed=false |
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Hi @haripate @tomasbakk I fixed the previous errors and rebased the commits. |
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
…-operatorhub#3) Signed-off-by: pablo_silberkasten <[email protected]>
…-operatorhub#3) Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Adding Oracle Database Operator Signed-off-by: pablo_silberkasten <[email protected]>
Signed-off-by: pablo_silberkasten <[email protected]>
Dear @psilberk, Errors (:bug:) must be fixed while warnings (:warning:) are informative, and fixing them might improve the quality of your solution.
|
Hi guys, sorry for keep reaching out, but at this point I don't know how to fix the validation, so if you can't provide any insights I will just drop Oracle's contribution to this project. |
@psilberk I will look into the issue. |
@mporrato could you help Pablo to figure out this issue? |
@psilberk Looks like something went wrong in the rebase: I see there are over 300 modified files across multiple operators. I would suggest closing this PR and submit a new one from scratch. |
Trying another one from scratch |
Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions
Updates to existing Operators
ci.yaml
file according to the update instructions?replaces
property if you chosereplaces-mode
via theupdateGraph
property inci.yaml
?package.yaml
orannotations.yaml
?Your submission should not
Operator Description must contain (in order)
Operator Metadata should contain
Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here