Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scan for GUIDs #837

Closed
wants to merge 6 commits into from
Closed

Scan for GUIDs #837

wants to merge 6 commits into from

Conversation

punkerpunker
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

punkerpunker
punkerpunker commented Jan 29, 2025
View reviewed changes
controllers/generic_network_controller.go
return ctrl.Result{RequeueAfter: time.Second * 5}, nil
}

nodeState := nodeStateList.Items[0]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is questionable

punkerpunker
punkerpunker commented Jan 29, 2025
View reviewed changes
api/v1/helper.go
if guid := GetGUIDFromSriovNetworkNodeStateStatus(status, cr.Spec.InterfaceName); guid != "" {
data.Data["GUID"] = guid
}
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much the same as RenderNetAttDef except 4 lines above

@punkerpunker
Copy link
Author

Supposed to be a fork, sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@punkerpunker