Allow update of CassandraDatacenter to be processed to StatefulSets i… #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
force-pushed
the
check_rack_podtemplate_changes
branch
from
287d162 to
fd2b3cb
Compare
burmanm
force-pushed
the
check_rack_podtemplate_changes
branch
from
fd2b3cb to
a4ae065
Compare
adejanovski
reviewed
Feb 17, 2025
There was a problem hiding this comment.
I was able to test this with a failed upgrade to a version of Cassandra that doesn't exist.
But I ran into a problem with the following scenario:
- I created a cluster with 1G for initial and max heap.
- Once it was started, I updated it with a 256M initial heap size and 128M max heap size.
- The pod never gets more than one restart, so any fix wouldn't be applied.
- I tried to use forceUpgradeRacks then, but it didn't apply the fix either:
forceUpgradeRacks:
- rack1
managementApiAuth:
insecure: {}
racks:
- name: rack1
Here's my full manifest:
apiVersion: cassandra.datastax.com/v1beta1
kind: CassandraDatacenter
metadata:
name: test-cluster
namespace: cass-operator
spec:
clusterName: development
config:
cassandra-yaml:
authenticator: PasswordAuthenticator
authorizer: CassandraAuthorizer
num_tokens: 16
role_manager: CassandraRoleManager
jvm-server-options:
initial_heap_size: 1G
max_heap_size: 1G
configBuilderResources: {}
managementApiAuth:
insecure: {}
racks:
- name: rack1
resources:
requests:
cpu: 1500m
memory: 2Gi
serverType: cassandra
serverVersion: 4.1.5
size: 3
storageConfig:
cassandraDataVolumeClaimSpec:
accessModes:
- ReadWriteOnce
resources:
requests:
storage: 10Gi
storageClassName: standard
…f the Datacenter is running in unhealthy Kubernetes configuration. These could be scheduling related or pods crashing
… ForceRackUpgrade is not set and fix some missing () for ifs
…first StartTime status.
burmanm
force-pushed
the
check_rack_podtemplate_changes
branch
from
ff9ea1b to
819e6b5
Compare
adejanovski
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f the Datacenter is running in unhealthy Kubernetes configuration. These could be scheduling related or pods crashing
What this PR does:
Which issue(s) this PR fixes:
Fixes #583
Checklist