Update HCD 1.2 Agent for CC 5.0.2 #594
Conversation
emerkle826
force-pushed
the
update-hcd
branch
from
b08cc7b to
8043f59
Compare
| requestExecute.invoke(request, qstate, forImmediateExecution.invoke(null)); | ||
|
|
||
| } catch (ClassNotFoundException cfne) { | ||
| logger.debug( |
There was a problem hiding this comment.
I guess we will never need this part of the code in HCD? Or in 5.0.
There was a problem hiding this comment.
Probably not, unless an HCD 1.2 image is built with a Converged Core 5 version that has specific commits that make the Dispatcher method signatures match this stuff here.
Honestly, this reflection stuff is not great, but the only alternative is to duplicate the code out into more agent submodules for specific point releases of the C*/DSE/HCD server code. They are pretty good at not changing the API within a . release, but this isn't exactly public APIs we are using. But I digress....
There was a problem hiding this comment.
To add to this, the main reason I'm leaving this code in place is in the case HCD needs to release a new 1.2 version and my patch for it to upgrade the Converged Core version does not get merged before the release. Removing the old code here would create a situation where the Agent is using a Dispatcher signature that doesn't exist in the HCD build.
Fixes #593