Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate pandoc rendering and scope it to repl only. #315

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

jmcardon
Copy link
Member

@jmcardon jmcardon commented Jan 30, 2025

Add multi-line detection for unclosed parens, add docs for missing natives, add test for pandoc roundtripping

Closes #302

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • (If Relevant) Documentation has been (manually) updated at https://docs.kadena.io/pact

Additionally, please justify why you should or should not do the following:

  • Benchmark regressions
  • Confirm replay/back compat (Ignore until core release)
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact (Ignore until core release)

…tection for unclosed parens, add docs for missing natives
Copy link
Contributor

@lsgunnlsgunn lsgunnlsgunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a quick review, this looks good. Feel free to merge and I'll pull the new functions into the docs repo, then make any edits (like I did with load) after that as a follow on PR.

@@ -0,0 +1,29 @@
## cond
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsgunnlsgunn can you check these int he future?

@@ -0,0 +1,32 @@
## env-set-milligas

Use `env-milligas` to set the current gas state to a specific value in milligas, similar to `env-gas` but 1 gas = 1e3 milligas
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect

docs/builtins/Repl/sig-keyset.md Outdated Show resolved Hide resolved

| Argument | Type | Description |
|----------|----------|--------------------------------------------------------------|
| capability | cap-token | Specifies the capability and scope to test |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually unsure if its now capability or capability...

@@ -338,6 +337,7 @@ emptyTxState = do
envSetDebug :: NativeFunction 'ReplRuntime ReplCoreBuiltin FileLocSpanInfo
envSetDebug info b _env = \case
[VString flag] -> do
-- Note: if these change, please change `env-set-debug-flags.md`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmcardon jmcardon merged commit 9cc8f57 into master Jan 31, 2025
8 checks passed
@jmcardon jmcardon deleted the jose/fix-pandoc-render branch January 31, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP hover documentation is broken due to wrong text formatting
3 participants