Problem when using with artwells/meteor-accounts-guest #142

alansikora · 2015-10-12T14:51:16Z

There is a problem at PublishContext, line 44:

PublishContext.prototype.changed = function(collection, id, fields) {
  var collectionData = this._collectionData;

  collectionData[collection] = collectionData[collection].map(function(doc) {
    if (doc._id === id) {
      return _.extend(doc, fields);
    }

    return doc;
  });
};

It tries to map to an undefined array when using artwells/meteor-accounts-guest package.

I'm on a really tight deadline so I could not really study the reasons, but I believe we need to keep that map safe by making a simple change.

Change PublishContext.changed() and PublishContext.removed() to ensure that the collection exists, and if there isn't a doc with the requested id in the current publish context, to look for one that was published in another publish context. If one is found, changed() adds the doc to the current publish context and removed() does nothing. If there isn't, both throw the same errors that would be thrown by the merge box.

brettle · 2015-12-08T19:52:21Z

PR #154 fixes this.

alansikora mentioned this issue Oct 12, 2015

add safe assign line to make sure map is not trying to loop on top of undefined #143

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Problem when using with artwells/meteor-accounts-guest #142

Problem when using with artwells/meteor-accounts-guest #142

alansikora commented Oct 12, 2015

brettle commented Dec 8, 2015

Problem when using with artwells/meteor-accounts-guest #142

Problem when using with artwells/meteor-accounts-guest #142

Comments

alansikora commented Oct 12, 2015

brettle commented Dec 8, 2015