Skip to content

Commit

Permalink
Merge pull request #420 from klarna/jesperes/fix-unknown-types
Browse files Browse the repository at this point in the history
Fix unknown types (one typo and one missing export)
  • Loading branch information
jesperes authored Oct 2, 2020
2 parents 834f9a3 + 93c50ec commit f9703fb
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 11 deletions.
1 change: 1 addition & 0 deletions rebar.config
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

{ct_opts, [{enable_builtin_hooks, false}]}.

{dialyzer, [{warnings, [unknown]}]}.
{cover_enabled, true}.
{cover_opts, [verbose]}.
{cover_export_enabled, true}.
Expand Down
2 changes: 1 addition & 1 deletion src/brod_group_subscriber_v2.erl
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
-callback init(brod_group_subscriber_v2:init_info(), _CbConfig) ->
{ok, _State}.

-callback handle_message(brod:kafka_message(), State) ->
-callback handle_message(brod:message(), State) ->
{ok, commit, State}
| {ok, ack, State}
| {ok, State}.
Expand Down
2 changes: 2 additions & 0 deletions src/brod_group_subscriber_worker.erl
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
, commit_fun :: brod_group_subscriber_v2:commit_fun()
}).

-export_type([start_options/0]).

%%%===================================================================
%%% brod_topic_subscriber callbacks
%%%===================================================================
Expand Down
11 changes: 1 addition & 10 deletions src/brod_topic_subscriber.erl
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,9 @@
-export_type([ cb_ret/0
, cb_fun/0
, committed_offsets/0
, topic_subscriber_config/0
]).

-type topic_subscriber_config_fun() ::
#{ client := brod:client()
, topic := brod:topic()
, cb_fun := module()
, message_type => message | message_set
, consumer_config => brod:consumer_config()
, partitions => all | [brod:partition()]
, committed_offsets => brod:committed_offsets()
}.

-type topic_subscriber_config() ::
#{ client := brod:client()
, topic := brod:topic()
Expand Down

0 comments on commit f9703fb

Please sign in to comment.