Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: introduce cleaner APIs for starting workers #375

Open
k32 opened this issue Mar 25, 2020 · 0 comments
Open

Proposal: introduce cleaner APIs for starting workers #375

k32 opened this issue Mar 25, 2020 · 0 comments

Comments

@k32
Copy link

k32 commented Mar 25, 2020

Currently brod API functions for starting worker processes pass each individual option as a function argument. However, number of arguments tends to get large as more options are added, which leads to the code that is fairly hard to read. I suggest to pass all options in a single map instead, in the same way it's done here: https://github.com/klarna/brod/blob/master/src/brod_group_subscriber_v2.erl#L168

Old APIs will be kept for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant