Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'string' of undefined #42

Open
pratik14 opened this issue Jan 11, 2018 · 4 comments
Open

TypeError: Cannot read property 'string' of undefined #42

pratik14 opened this issue Jan 11, 2018 · 4 comments

Comments

@pratik14
Copy link

Support for React 16. Proptype is deprecated I think we need to add prop-types library instead

@benji011
Copy link

Hi
I ran into this issue to. Has there been a fix yet?

@benji011
Copy link

benji011 commented Feb 21, 2018

Hi,

Error is coming from here:

	InlineEdit.propTypes = {
	    text: _react2.default.PropTypes.string.isRequired,
	    paramName: _react2.default.PropTypes.string.isRequired,

where PropTypes of string is undefined.
Is there a workaround?

@pratik14
Copy link
Author

pratik14 commented Feb 21, 2018

@benji011 checkout this PR(#41). He has made necessary changes. Fork the project and add those changes to use.

@iyobo
Copy link

iyobo commented Jul 1, 2018

This is because proptypes is no longer a part of react as at v16.
The project should npm i react-proptypes and use that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants