-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
강원대 FE_최서린 6주차 과제 Step1,2 #72
Open
seorinnn
wants to merge
19
commits into
kakao-tech-campus-2nd-step2:seorinnn
Choose a base branch
from
seorinnn:feat-choiseorin
base: seorinnn
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
강원대 FE_최서린 6주차 과제 Step1,2 #72
seorinnn
wants to merge
19
commits into
kakao-tech-campus-2nd-step2:seorinnn
from
seorinnn:feat-choiseorin
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazy-sky
requested changes
Aug 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안녕하세요, 서린님
리뷰 요청이 오지 않아 확인이 늦었네요. step0에 해당하는 부분이 함께 있어 커밋 단위로 코멘트를 남겨두도록 하겠습니다. 배포까지 수고하셨습니다!
수정 요구드릴 사항은 없는 거 같네요. 충돌만 해결하시면 될 거 같습니다! |
아 배포된 페이지도 첨부해주세요~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 멘토님 !
드디어 마지막 주차네요 ㅎㅎ 멘토님도 정말 수고 많으셨습니다 !!
수정할 부분이 있다면 말씀해주세요!
아래 코멘트는 8.6(화)에 재제출 하며 작성하였습니다.
재제출하며 새로 추가한 내용
멘토님 피드백 1 :
useSuspenseQuery
와useQuery
의 차이점로딩 및 에러 처리, 환경 설정에 차이점이 있다.
useQuery
는 로딩 및 에러 처리를 직접 처리해야 하지만,useSuspenseQuery
는 Suspense의 fallback UI로 처리한다.useSuspenseQuery
를 사용하여 코드의 복잡성을 줄일 수 있다.멘토님 피드백 2 : 배포한 페이지
https://seorinnn.github.io/react-deploy