Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in dependencies at build time instead of storing them as source #2

Open
gggeek opened this issue May 30, 2018 · 0 comments
Open
Assignees

Comments

@gggeek
Copy link

gggeek commented May 30, 2018

In order to make it easier to maintain this package, it would make more sense to not have a copy of all the dependencies stored in the "lib" folder, but instead only pull them in at build time.
The advantage would also be that the tarball gotten from github would be smaller, as it would include 'just' the phar file.

One idea about how to achieve this could be to use a separate composer.json file that declares the required php depenendencies and it used by makephar.php, but is not parsed when the main composer.json of this project is parsed by the top-level project :-)

@fvsch fvsch self-assigned this May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants