-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mouse support configurable #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I would like turning off mouse support to be able to select text.
As it is, when mouse is enabled or disabled, text cannot be selected via mouse.
So some programmatic way to use MouseTerminal
I really dislike this solution, made me change the signature of some functions to pass |
An alternative solution could be to keep the mouse feature, have it enabled by default and can be changed via config (the work you did). |
Not sure what you mean, as it is right now in this branch it is done only through the config (there wouldn't be a need for a cargo feature).
After the latest commits this is achieved tho, what you wanted should be the current behaviour. |
Not sure if I explained myself, sorry if I wasn't too clear 😅 |
Okay, this is fine. I am content with this haha. |
Thanks! |
Implements request of issue #402 for mouse support to be configurable through
joshuto.toml
instead of it being a cargo feature.