Add minimal display mode #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flipsi
commented
Oct 26, 2024
| @@ -4,7 +4,7 @@ use ratatui::widgets::Widget; | |||
|
|
|||
| use crate::types::option::display::DisplayMode; | |||
| use crate::types::state::AppState; | |||
| use crate::ui::views::{TuiFolderView, TuiHSplitView}; | |||
| use crate::ui::views::{tui_minimal_view::TuiMinimalView, TuiFolderView, TuiHSplitView}; | |||
There was a problem hiding this comment.
I don't understand why I had to qualify this to make it compile, any help/explanation is appreciated.
There was a problem hiding this comment.
if you add
pub use self::tui_minimal_view::*;then it won't require you to do this. Up to you on if you add it though, I don't have a huge preference and will probably change it later anyways xd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new display mode referred to as
minimal.It does exactly what it says on the tin - basically the current tab content is rendered full size (no miller columns like in
default, no multipanes like inhsplit).This is similar to the
multipaneview in ranger when there is only one tab.Disclaimer: I was personally missing this feature and built it by copy-pasting and cutting down existing code - not really knowing Rust. I hope I didn't miss anything important.