Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace manual sign detection with format spec "+" #577

Merged
merged 2 commits into from
Nov 9, 2024
Merged

refactor: replace manual sign detection with format spec "+" #577

merged 2 commits into from
Nov 9, 2024

Conversation

Integral-Tech
Copy link
Contributor

+ - This is intended for numeric types and indicates that the sign should always be printed. By default only the negative sign of signed values is printed, and the sign of positive or unsigned values is omitted. This flag indicates that the correct sign (+ or -) should always be printed.

@Integral-Tech Integral-Tech changed the title refactor: replace manaul sign detection with format spec "+" refactor: replace manual sign detection with format spec "+" Nov 5, 2024
@Integral-Tech
Copy link
Contributor Author

@kamiyaa CI fails on the main branch due to code format. I have fixed it in my PR :)

kamiyaa
kamiyaa reviewed Nov 9, 2024
View reviewed changes
Copy link
Owner

@kamiyaa kamiyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kamiyaa kamiyaa merged commit 4b4b779 into kamiyaa:main Nov 9, 2024
4 checks passed
@Integral-Tech Integral-Tech deleted the sign-detect-plus branch November 9, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamiyaa kamiyaa kamiyaa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integral-Tech @kamiyaa