correctly parse HTML4 nested inline elements (#861)

fixes #857
kangax · Oct 17, 2017 · 9a45eb4 · 9a45eb4
1 parent e0108f9
commit 9a45eb4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/htmlparser.js b/src/htmlparser.js
@@ -270,7 +270,7 @@ function HTMLParser(html, handler) {
       parseEndTag('', lastTag);
     }
 
-    if (!handler.html5) {
+    if (!handler.html5 && !inline(tagName)) {
       while (lastTag && inline(lastTag)) {
         parseEndTag('', lastTag);
       }

diff --git a/tests/minifier.js b/tests/minifier.js
@@ -1635,6 +1635,16 @@ QUnit.test('custom components', function(assert) {
   assert.equal(minify(input), output);
 });
 
+QUnit.test('HTML4: anchor with inline elements', function(assert) {
+  var input = '<a href="#"><span>Well, look at me! I\'m a span!</span></a>';
+  assert.equal(minify(input, { html5: false }), input);
+});
+
+QUnit.test('HTML5: anchor with inline elements', function(assert) {
+  var input = '<a href="#"><span>Well, look at me! I\'m a span!</span></a>';
+  assert.equal(minify(input, { html5: true }), input);
+});
+
 QUnit.test('HTML4: anchor with block elements', function(assert) {
   var input = '<a href="#"><div>Well, look at me! I\'m a div!</div></a>';
   var output = '<a href="#"></a><div>Well, look at me! I\'m a div!</div>';