fix: destroy attached volumes after a server destroy #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kaorimatz#15. A `vagrant destroy` when the server is running will call `server.terminate`, which destroys attached volumes. A `vagrant destroy` when the server is halted will call `server.destroy`, which does not destroy attached volumes. This commit addresses the second case and delete each volume seperately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.
A
vagrant destroywhen the server is running will callserver.terminate, which destroys attached volumes.A
vagrant destroywhen the server is halted will callserver.destroy, which does not destroy attached volumes.This commit addresses the second case and delete each volume seperately.