fix: don't blow stack on recursive object (#504)

kaplayjs · Nov 10, 2024 · f00a7d6 · f00a7d6
1 parent 7aea915
commit f00a7d6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/examples/prettyDebug.js b/examples/prettyDebug.js
@@ -10,6 +10,8 @@ const pretty = {
     "own toString is used": vec2(10, 10),
 };
 
+pretty.recursive = pretty;
+
 debug.log("Text in [brackets] doesn't cause issues");
 
 debug.log(pretty);

diff --git a/src/gfx/draw/drawDebug.ts b/src/gfx/draw/drawDebug.ts
@@ -219,15 +219,16 @@ export function drawDebug() {
     }
 }
 
-function prettyDebug(object: any | undefined, inside: boolean = false): string {
+function prettyDebug(object: any | undefined, inside: boolean = false, seen: Set<any> = new Set): string {
+    if (seen.has(object)) return "<recursive>";
     var outStr = "", tmp;
     if (inside && typeof object === "string") {
         object = JSON.stringify(object);
     }
     if (Array.isArray(object)) {
         outStr = [
             "[",
-            object.map(e => prettyDebug(e, true)).join(", "),
+            object.map(e => prettyDebug(e, true, seen.union(new Set([object])))).join(", "),
             "]",
         ].join("");
         object = outStr;
@@ -244,7 +245,7 @@ function prettyDebug(object: any | undefined, inside: boolean = false): string {
             (tmp = Object.getOwnPropertyNames(object)
                     .map(p =>
                         `${/^\w+$/.test(p) ? p : JSON.stringify(p)}: ${
-                            prettyDebug(object[p], true)
+                            prettyDebug(object[p], true, seen.union(new Set([object])))
                         }`
                     )
                     .join(", "))