Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show locale code in lyric translation list #2262

Open
CloneWith opened this issue Jul 15, 2024 · 4 comments
Open

Show locale code in lyric translation list #2262

CloneWith opened this issue Jul 15, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@CloneWith
Copy link
Contributor

When the font needed for displaying characters in the translation language selection list, they are shown as ?. Thus it might be nice to display a corresponding language code beside each entry (e.g. "中文 (zh)"), after all you use language codes for searching.

Locale List in karaoke settings screen

And is the list a little too long? 🤔

@andy840119
Copy link
Member

I geuss it's because it shows the whole coltureInfo (language and language with culture)
e.g.

  • Chinese is langualge
  • Chinese(zh-tw) is language with culture because it's the chinese for Taiwan only.

I'm not very sure which one should be used eventually.

@andy840119
Copy link
Member

And ????? is because some character is not supported in the font store.
"中文 (zh)" might be "?? (zh)" if font store does not support the chinese character.

@CloneWith
Copy link
Contributor Author

I'm not very sure which one should be used eventually.

Me too. And what about detecting system locale as the default setting?

Just now I tried to use CultureInfo.CurrentUICulture and CurrentCulture for locale detection, which both return 中文. I think it can't assert the precise locale where we are, since it isn't always bonded with language ("中文(新加坡)", etc. exist)

As of now, it's better to keep both of them, and users might select the most suitable one manually.

@andy840119
Copy link
Member

And what about detecting system locale as the default setting?

Should be better to follow the language in lazer, but lazer use the enum. Maybe write utils to convert the enum to CultureInfo will be the final solution
This is lower priority because user can still change it.

@andy840119 andy840119 added the bug Something isn't working label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants