Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate main script / entry point #10

Open
marc-portier opened this issue Feb 23, 2014 · 9 comments
Open

Remove duplicate main script / entry point #10

marc-portier opened this issue Feb 23, 2014 · 9 comments
Milestone

Comments

@marc-portier
Copy link
Collaborator

Currently there is node launcher.js and node mngr.js ->> this should become one, and documented.

@karel1980
Copy link
Owner

I'm ok with having both. For development having a quick launch-comm is much handier than having to go via the manager (rest / webapp) to quickly and repeatedly setting up comms.

@karel1980 karel1980 added this to the 0.9 milestone Feb 23, 2014
@karel1980
Copy link
Owner

Assigned to 0.9. Move the launch-comm script under dev/misc/tools and document it for now as the 'developer' way of launching comms

@karel1980
Copy link
Owner

Closed by accident

@karel1980 karel1980 reopened this Feb 23, 2014
@marc-portier
Copy link
Collaborator Author

The point is that the launcher is designed (maybe needs to changes) to just support that use case.
By adding an extra parameter you can select a certain (test-focussed) config to be used.
Without that extra cli argument it uses config/launcher/me.json

So what I really like to say with this issue is:

  • having "persistent" comms to be able to fire up at launch is useful in the final thing too?
  • let's agree on how to adapt the config to hold all we need to setup of all to be launched services
  • let's make sure we use the full stack in all dev test cases as soon as possible - making sure we enforce convergence between devs sooner rather then later
  • me.json should probably be removed from the repo and should be where each instance persists his own set of -gathered service descriptions, -comms you might want to have up and running after each restart
  • maybe we should allow the mngr to implement a "save" button to persist the current state into me.json to have available at next launch

@karel1980
Copy link
Owner

I'm currently working towards this. Depending on how much time I have and how fast it progresses I may split it up in more tasks

@karel1980
Copy link
Owner

Mngr.js is now called scratchnet.js. The other one is moved under dev-scripts. I am pretty close to eliminating The need for the other one

@karel1980
Copy link
Owner

See 069c0cd. We don't do persistent comms yet, but it's dead easy to start 2 instances locally and connect them directly.

Note: you can start a single manager and have it create a link with 2 comms (nodejs scratchnet 2000:2000:chat-1.0), but you can't yet have a link with a single comm looping back on itself)

@marc-portier
Copy link
Collaborator Author

Just to clarify & make sure we understand the same thing:

  • the described loopback to your own local comm is possible (in the comm)
  • but there is currently no easy way to do that in the mngr-ui

right?

@karel1980
Copy link
Owner

That's right

Marc Portier [email protected]:

Just to clarify & make sure we understand the same thing:

  • the described loopback to your own local comm is possible (in the comm)
  • but there is currently no easy way to do that in the mngr-ui

right?

Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-36425477.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants