-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Prow to v20240517-ea10bd814 #4637
Comments
I tested the basic functionality against the karmada-io/website#563 and it works well. Here is the main configuration update(add the apiVersion: v1
kind: ConfigMap
metadata:
namespace: karmada-prowbot
name: config
data:
config.yaml: |
triggers:
- repos:
- karmada-io/karmada
- karmada-io/website
# JoinOrgURL is a link that redirects users to a location where they
# should be able to read more about joining the organization in order
# to become trusted members.
join_org_url: "https://github.com/karmada-io/community/blob/main/community-membership.md#member"
only_org_members: true
# TriggerGitHubWorkflows enables workflows run by github to be triggered by prow.
trigger_github_workflows: true |
I tried it in my env and it works fine: https://github.com/jwcesign/kubectl-proxy-demo/pull/3 My config: apiVersion: v1
kind: ConfigMap
metadata:
namespace: prow
name: plugins
data:
plugins.yaml: |
triggers:
- repos:
- jwcesign/kubectl-proxy-demo
trigger_github_workflows: true
plugins:
jwcesign/kubectl-proxy-demo:
plugins:
- approve
- assign
- blunderbuss
- cat
- dog
- help
- heart
- hold
- label
- lgtm
- trigger
- verify-owners
- wip
- yuks Did the relevant components restart after the configuration update? @RainbowMango |
It works now. See the test PR karmada-io/website#567. |
The Prow version now has been promoted to v20240517-ea10bd814. |
/close |
@RainbowMango: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why is this needed:
We want the feature that triggers failed workflow which was introduced since v20220105-8e97316bf9.
See the discussion #3421 (comment) for more details.
Migration progress:
All images can be found here: https://console.cloud.google.com/gcr/images/k8s-prow
The text was updated successfully, but these errors were encountered: