Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fix size is not friendly with a responsive design #29

Open
lestcape opened this issue Jan 12, 2023 · 1 comment
Open

A fix size is not friendly with a responsive design #29

lestcape opened this issue Jan 12, 2023 · 1 comment

Comments

@lestcape
Copy link

lestcape commented Jan 12, 2023

By reading the "README.md" we can think that this project want to target the bootstrap framework some how or at less be compatible with it. Unfortunately the plugin works by moving a preset image in the background which forces the kv-score bar to have a fixed size, losing the opportunity to really be responsive.

Fortunately it is very easy to stop using a background image and instead set a background color for the score box avoiding the need to set a width and making the plugin friendly with a responsive design.

Please see some ideas of how to implement the background color of the kv-score box, without the usage of an image here:
https://stackoverflow.com/questions/7128675/from-green-to-red-color-depend-on-percentage

Example:

This is an example of how i fixed this problem from outside the plugin, without to touch the code, but for sure will be preferable if strength-meter is already prepared to work with percentages and not with a fixed box width.

https://jsfiddle.net/lestcape/j0exbomq/

@kartik-v
Copy link
Owner

Thanks for the feedback. This project was done years back. Will definitely look into your suggestions when I get time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants