Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Better display lyrics #111

Open
tisfeng opened this issue Nov 2, 2024 · 8 comments
Open

Feature Request: Better display lyrics #111

tisfeng opened this issue Nov 2, 2024 · 8 comments
Assignees

Comments

@tisfeng
Copy link
Contributor

tisfeng commented Nov 2, 2024

Hello, aural-player is a very powerful player, and I really like its design style. Thank you for your development!

I noticed that aural-player has a feature to display lyrics, but currently, the layout of the lyrics is not good, and it does not support dynamic lyrics display.

I am used to listening to songs while looking at the lyrics because some songs have amazing lyrics, and the lyrics are an inseparable part of the song.

I hope aural-player has a better way to conveniently display the lyrics, rather than placing them under the song information. It would be even better if it could support dynamic lyrics.

image
@kartik-venugopal
Copy link
Owner

kartik-venugopal commented Nov 7, 2024

Hi @tisfeng , thanks very much for the request. So, I guess there are 2 parts to your request: 1 - Having a separate panel for the lyrics, and 2 - dynamic lyrics support. Number 1 is easy, so let's talk about number 2.

Yes, I agree, it would be good to display dynamic lyrics, and I have thought about this in the past, but have not been able to find a song with dynamic lyrics, so I don't know what the format is like.

I understand that this may be difficult, but for the sake of development of this feature, are you able to share with me a song sample that has dynamic lyrics ? Or do you know where I can get such a file for free ?

Thanks!

@tisfeng
Copy link
Contributor Author

tisfeng commented Nov 8, 2024

Of course, the common lyric format used in songs is LRC_(file_format), and most music software supports displaying this format of lyrics.

As for the source of the lyric file lrc, some music apps will embed the lrc file when downloading music, while others may provide a separate lrc lyric file download with the song's name.

If the music app does not provide a lyric file, we can even make one ourselves, as its format is very simple.

Here is an example song Fools

song: Anna F.-Fools.mp3.zip
lyric: Anna F.-Fools.lrc.zip

@tisfeng
Copy link
Contributor Author

tisfeng commented Nov 8, 2024

I haven't looked at the code yet. Aural seems to read the embedded lyrics in the songs, which is a simple method. However, for the songs we usually download from the internet, they typically do not come with lyrics, so an additional .lrc file would be needed.

I found a website for online searching of lrc files: https://www.toomic.com/?search=fools, which makes it easy to download lyrics.

Currently, Aural only supports playing local music, so we only need to consider the two situations mentioned above. If we later want to support playing online songs, we can use this method to display the lyrics.

image image

@kartik-venugopal
Copy link
Owner

Thanks very much for the info. One more question - where would you like to see the lyrice displayed ? In a separate window ?

I will try to get this implemented soon, but I have a lot of pending work for the v4 release and I'm a one man army, so hope you understand that it may take some time.

Cheers! 😄

@tisfeng
Copy link
Contributor Author

tisfeng commented Nov 10, 2024

where would you like to see the lyrics displayed ? In a separate window ?

This sounds great. I noticed that Aural has some independent function windows, such as Play Queue and Effects, which users can choose to display freely. This design is fantastic.

I like this open-source lyrics project LyricsX. It allows for easy lyric searching and dynamic lyric display. Hope this helps you.

I am looking forward to the lyrics feature. Thank you for your great work on Aural 🤗

image

@tisfeng
Copy link
Contributor Author

tisfeng commented Dec 22, 2024

Hi, I've implemented the dynamic lyrics feature in a basic way. If you haven't done it yet, you can assign it to me.

I'm not familiar with the aural code, so it might not be perfect, but it runs. It seems okay, and you can optimize it later.

image

@kartik-venugopal
Copy link
Owner

Hi @tisfeng , that's great, thank you! Yes, I'm happy to include your code. Can you send me a pull request ? I can merge and add the finishing touches.

@tisfeng
Copy link
Contributor Author

tisfeng commented Dec 22, 2024

No problem, give me some time, I need to organize the code, and I will submit a PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants