Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse window restoration logic in Unified and Compact app modes #120

Open
kartik-venugopal opened this issue Dec 26, 2024 · 5 comments
Open

Comments

@kartik-venugopal
Copy link
Owner

Maybe consolidate / eliminate WLManager ?

@LesterJitsi
Copy link

Would you please elaborate a bit? Maybe with some screenshots of what you have in mind?

@kartik-venugopal
Copy link
Owner Author

kartik-venugopal commented Dec 27, 2024

Hey, sure. Currently, in Modular mode, there is some logic in place to ensure that when you open the app, the app windows will be visible on screen. This is important when switching between different monitor setups.

Imagine that you use a Macbook Pro connected to a huge ultrawide 34 inch monitor and you have set up Aural all the way to the right of the ultrawide screen. When you then unplug your MBP from the monitor and use the built-in display and open Aural, it will probably go off-screen since it's X co-ordinate is based on the ultrawide screen. Aural should make sure that the windows always show up on screen (keeping in mind X and Y co-ordinates). Window layout is remembered across app launches.

This logic should be copied over to the Unified and Compact app modes, so that they can benefit from it too. That's pretty much it.

Hope this makes sense ?

@kartik-venugopal
Copy link
Owner Author

kartik-venugopal commented Dec 27, 2024

This screenshot was taken on my 34 inch ultrawide monitor. Note that Aural would be outside the frame of a normal 16:9 or 16:10 screen like the built-in MBP display.

Screenshot 2024-12-27 at 11 51 45 AM

@LesterJitsi
Copy link

Hope this makes sense?

It does lots of sense of course. Sorry, I had misunderstood and could only guess at something of smaller importance. Thank you.

@kartik-venugopal
Copy link
Owner Author

No worries 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants